Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump CI jobs to Python 3.12 #2314

Merged
merged 3 commits into from
Oct 14, 2023
Merged

Bump CI jobs to Python 3.12 #2314

merged 3 commits into from
Oct 14, 2023

Conversation

jacobtylerwalls
Copy link
Member

No description provided.

@jacobtylerwalls jacobtylerwalls added the Maintenance Discussion or action around maintaining astroid or the dev workflow label Oct 2, 2023
@Pierre-Sassoulas Pierre-Sassoulas added the Blocked 🚧 A PR or issue blocked by another PR or issue label Oct 2, 2023
@Pierre-Sassoulas
Copy link
Member

Blocked by 3.12 being released in the github available runners (can't find the repo but I'll link it later because I'm watching it and I'll get notified when 3.12 is up)

@Pierre-Sassoulas
Copy link
Member

@jacobtylerwalls jacobtylerwalls removed the Blocked 🚧 A PR or issue blocked by another PR or issue label Oct 3, 2023
.readthedocs.yaml Outdated Show resolved Hide resolved
@Pierre-Sassoulas
Copy link
Member

Pierre-Sassoulas commented Oct 14, 2023

Same pypy 3.10 bug is happening elsewhere : #2316 I think main is broken.

@jacobtylerwalls
Copy link
Member Author

jacobtylerwalls commented Oct 14, 2023

OK to merge this then? Don't want to spend any open source banana sundae points with a no-approval-merge 😉

@jacobtylerwalls
Copy link
Member Author

jacobtylerwalls commented Oct 14, 2023

I'll delete the cache and rerun it. edit: that took care of it!

@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #2314 (2293334) into main (0883b04) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2314   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files          94       94           
  Lines       11056    11056           
=======================================
  Hits        10266    10266           
  Misses        790      790           
Flag Coverage Δ
linux 92.66% <ø> (ø)
pypy 91.00% <ø> (ø)
windows 92.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@Pierre-Sassoulas Pierre-Sassoulas merged commit c9f9924 into main Oct 14, 2023
20 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the bumpc-i branch October 14, 2023 21:42
@Pierre-Sassoulas
Copy link
Member

Don't want to spend any open source banana sundae points with a no-approval-merge

In truth the sweet banana sundae point (and money for increasing said points) for well reviewed code is no more :(. But sometime I think a review is not necessary and then I break main in multiple unexpected ways or a review happen and something obvious is pointed out so review is always better (but we don't have to be zealots about it either)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Discussion or action around maintaining astroid or the dev workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants