-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pyreverse documentation #10063
Improve pyreverse documentation #10063
Conversation
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #10063 +/- ##
=======================================
Coverage 95.79% 95.80%
=======================================
Files 174 174
Lines 18940 18962 +22
=======================================
+ Hits 18144 18166 +22
Misses 796 796 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed the change I thought of (easier done than explained). Would you mind checking the result @DanielNoord ?
I think this is intentional, because these sections are all on the same page. For me, if I click on Filtering and Scope, it just scrolls to the according section. |
Yes, but shouldn't it be another dropdown? They are on a different level than "Basic Usage" section wise, so it shouldn't be on the same level I think? |
I don't know if we can do anything about it, isn't it a bug or feature from Sphinx auto generated toc ? (Moving them one level down, that we can do) |
:height: 1452 | ||
:alt: Package diagram generated by pyreverse | ||
:align: center | ||
|
||
.. toctree:: | ||
:maxdepth: 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we tweak this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm trying to currently, we managed to do it for the dev guide so I should be able to.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is surprisingly hard. Might have to change the headings underline again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a possible solution that fixes both the heading hierarchy and improves the documentation readability. Would you like me to create a commit with these changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure @Julfried, thank you for proposing (I tried to increase maxdepth without success)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my idea. One thing I noticed: this table of contents collapses when the window is narrow on smaller screens. Maybe this could be fixed in the theme settings. What do you think?
abaf72e
to
18ee1c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the current version is good enough β’οΈ (especially with the mini-toc created manually in Usage) Let me know what you think @DanielNoord :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Type of Changes
Description
Follow up to 10045