Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle latest PyMC/PyTensor breaking changes #352

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

ricardoV94
Copy link
Member

No description provided.

@ricardoV94 ricardoV94 force-pushed the bump_dependency branch 2 times, most recently from 39736c1 to 6db16e5 Compare June 25, 2024 20:45
@ricardoV94 ricardoV94 changed the title Update to latest PyMC API Handle latest PyMC/PyTensor breaking changes Jun 25, 2024
@ricardoV94
Copy link
Member Author

ricardoV94 commented Jun 26, 2024

@ciguaran @aloctavodia, there's an SMC error that I think is unrelated, probably something changed in blackjax?

AttributeError: module 'blackjax.smc.adaptive_tempered' has no attribute 'adaptive_tempered_smc'

How should I fix it?
Also SMC is inside the inference module, shouldn't it be in its own module. In the PyMC repo inference is specific to VI stuff?

@ricardoV94
Copy link
Member Author

Still some broken stuff, but almost done

@ricardoV94
Copy link
Member Author

ricardoV94 commented Jun 26, 2024

Ok 4 failing tests, one marginal, two smc, and one statespace.

@jessegrabowski: FAILED pymc_experimental/tests/statespace/test_VARMAX.py::test_impulse_response[scalar_shock_size] - ValueError: initial_shock has 0 dims but 1 dim labels were provided.

Easy fix?

@jessegrabowski
Copy link
Member

Should be fixed by #346

@ricardoV94
Copy link
Member Author

@jessegrabowski can we fix just the dim here? Otherwise this PR depends on that and that one will depend on this, unless you put all commits from this PR there?

@jessegrabowski
Copy link
Member

Sure np

@ricardoV94
Copy link
Member Author

Sure np

Can you push or tell me what to change. If it's convoluted I can also just mark it as xfail?

@jessegrabowski
Copy link
Member

I'm doing it now, give me about an hour

@ricardoV94
Copy link
Member Author

I'm doing it now, give me about an hour

Counting

@zaxtax
Copy link
Contributor

zaxtax commented Jun 26, 2024

What other files are still giving errors?

@ricardoV94
Copy link
Member Author

One marginal test and two SMC tests

@ciguaran
Copy link
Contributor

@ricardoV94 hei! could you share the version of blackjax you are using? most likely you can fix it by replacing 'blackjax.smc.adaptive_tempered' with blackjax.adaptive_tempered_smc

@ricardoV94
Copy link
Member Author

@ciguaran other stuff is failing downstream after I update the function path. I'll mark it as xfail for now

@ricardoV94
Copy link
Member Author

ricardoV94 commented Jun 28, 2024

To unblock parallel work I marked two tests as xfail and opened issues for it

@jessegrabowski
Copy link
Member

Is this ready to merge?

@zaxtax
Copy link
Contributor

zaxtax commented Jun 28, 2024

We should bump the middle version number as part of this change

@ricardoV94 ricardoV94 merged commit 51704bd into pymc-devs:main Jun 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants