-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle latest PyMC/PyTensor breaking changes #352
Conversation
39736c1
to
6db16e5
Compare
@ciguaran @aloctavodia, there's an SMC error that I think is unrelated, probably something changed in blackjax? AttributeError: module 'blackjax.smc.adaptive_tempered' has no attribute 'adaptive_tempered_smc' How should I fix it? |
Still some broken stuff, but almost done |
6db16e5
to
94790c7
Compare
Ok 4 failing tests, one marginal, two smc, and one statespace. @jessegrabowski: FAILED pymc_experimental/tests/statespace/test_VARMAX.py::test_impulse_response[scalar_shock_size] - ValueError: initial_shock has 0 dims but 1 dim labels were provided. Easy fix? |
Should be fixed by #346 |
@jessegrabowski can we fix just the dim here? Otherwise this PR depends on that and that one will depend on this, unless you put all commits from this PR there? |
Sure np |
Can you push or tell me what to change. If it's convoluted I can also just mark it as xfail? |
I'm doing it now, give me about an hour |
Counting |
What other files are still giving errors? |
One marginal test and two SMC tests |
@ricardoV94 hei! could you share the version of blackjax you are using? most likely you can fix it by replacing ' |
@ciguaran other stuff is failing downstream after I update the function path. I'll mark it as xfail for now |
83ebb80
to
b72aa83
Compare
To unblock parallel work I marked two tests as xfail and opened issues for it |
Is this ready to merge? |
We should bump the middle version number as part of this change |
No description provided.