Bump PyMC version requirement #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
reviewed
Mar 1, 2025
|
Seems like we need to ignore the numpy import warning or pin tests to numpy<2.0. It's coming from pymc |
|
Why aren't tests failing on the pymc side? We also do |
|
We're not failing on warnings there. It was easier to do it here because we started from scratch with the testing suite |
|
oh duh it's |
jessegrabowski
force-pushed
the
remove-svd-normal-rewrite
branch
from
02b52dc to
907b083
Compare
jessegrabowski
force-pushed
the
remove-svd-normal-rewrite
branch
from
86cc6eb to
34c66ad
Compare
AlexAndorra
approved these changes
Mar 1, 2025
|
yes please! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #430
Related to #429
The latest pytensor release breaks several places in the statespace code. I was using a rewrite to introduce
method='svd'to multivariate_normal forward samples; this is no longer needed. There was also anif Variable:check, which now needs to beif Variable is not None.