Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user customization to plot_curve methods #1018

Merged
merged 14 commits into from
Sep 11, 2024
Merged

Conversation

wd60622
Copy link
Contributor

@wd60622 wd60622 commented Sep 11, 2024

Description

User can now specify:

  • same_axes to plot all the curves on the same axes
  • axes in the plot_curve method
  • colors in the plot_curve method
  • turn legend off and on with legend parameter
  • Change how the selection is displayed with sel_to_string parameter

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1018.org.readthedocs.build/en/1018/

@wd60622 wd60622 requested a review from juanitorduz September 11, 2024 02:34
@wd60622 wd60622 added enhancement New feature or request MMM plots labels Sep 11, 2024
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 98.47328% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.70%. Comparing base (d0f1fd6) to head (e179688).
Report is 93 commits behind head on main.

Files with missing lines Patch % Lines
pymc_marketing/mmm/plot.py 98.29% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1018      +/-   ##
==========================================
+ Coverage   95.61%   95.70%   +0.08%     
==========================================
  Files          38       38              
  Lines        3716     3792      +76     
==========================================
+ Hits         3553     3629      +76     
  Misses        163      163              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I just left some minor comments

pymc_marketing/mmm/plot.py Outdated Show resolved Hide resolved
pymc_marketing/mmm/plot.py Show resolved Hide resolved
@wd60622
Copy link
Contributor Author

wd60622 commented Sep 11, 2024

This should be good to go @juanitorduz

@wd60622 wd60622 merged commit 9362709 into main Sep 11, 2024
12 checks passed
@juanitorduz juanitorduz deleted the generalize-plotting branch September 11, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request MMM plots
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for additional customization in pymc_marketing.mmm.plot.plot_curve function
2 participants