-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CLV plot_expected_purchases_ppc
#1222
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1222 +/- ##
==========================================
+ Coverage 95.59% 95.64% +0.04%
==========================================
Files 39 39
Lines 4066 4089 +23
==========================================
+ Hits 3887 3911 +24
+ Misses 179 178 -1 ☔ View full report in Codecov by Sentry. |
Three extraneous tests for the |
plot_purchase_pmf
Plotting Functionplot_expected_purchases_ppc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🚀
@ColtAllen we have a fix for the mmm tests failing in #1240. You need to rebase and then we can merge (there are some lint fixes as well) |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Description
This PR adds a plotting function for prior and posterior predictive checks of customer purchases.
plot_expected_purchases_ppc(model, ppc='prior');
plot_expected_purchases_ppc(model, ppc='posterior');
I've created an issue for adding HDI ranges to these plots, and while revising the ParetoNBD notebook also removed a model file that was being created.
Related Issue
sample_prior_predictive
for CLV models #1155, Adapt Evaluation Plots fromlifetimes
#326, Add HDI ranges to CLVplot_expected_purchases_ppc
#1223Checklist
Modules affected
Type of change
📚 Documentation preview 📚: https://pymc-marketing--1222.org.readthedocs.build/en/1222/