Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLV plot_expected_purchases_ppc #1222

Merged
merged 23 commits into from
Nov 27, 2024
Merged

Conversation

ColtAllen
Copy link
Collaborator

@ColtAllen ColtAllen commented Nov 23, 2024

Description

This PR adds a plotting function for prior and posterior predictive checks of customer purchases.

plot_expected_purchases_ppc(model, ppc='prior');

image

plot_expected_purchases_ppc(model, ppc='posterior');

image

I've created an issue for adding HDI ranges to these plots, and while revising the ParetoNBD notebook also removed a model file that was being created.

Related Issue

Checklist

Modules affected

  • MMM
  • CLV

Type of change

  • New feature / enhancement
  • Bug fix
  • Documentation
  • Maintenance
  • Other (please specify):

📚 Documentation preview 📚: https://pymc-marketing--1222.org.readthedocs.build/en/1222/

@ColtAllen ColtAllen added this to the 0.11.0 milestone Nov 23, 2024
@ColtAllen ColtAllen self-assigned this Nov 23, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added the docs Improvements or additions to documentation label Nov 23, 2024
Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.64%. Comparing base (7abb6e7) to head (6b559f1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1222      +/-   ##
==========================================
+ Coverage   95.59%   95.64%   +0.04%     
==========================================
  Files          39       39              
  Lines        4066     4089      +23     
==========================================
+ Hits         3887     3911      +24     
+ Misses        179      178       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ColtAllen
Copy link
Collaborator Author

Three extraneous tests for the MMM and Prior modules are failing in the CI.

@ColtAllen ColtAllen changed the title Add CLV plot_purchase_pmf Plotting Function Add CLV plot_expected_purchases_ppc Nov 24, 2024
Copy link
Collaborator

@juanitorduz juanitorduz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! 🚀

@juanitorduz
Copy link
Collaborator

@ColtAllen we have a fix for the mmm tests failing in #1240. You need to rebase and then we can merge (there are some lint fixes as well)

@juanitorduz
Copy link
Collaborator

pre-commit.ci autofix

@juanitorduz juanitorduz merged commit 1464354 into pymc-labs:main Nov 27, 2024
13 checks passed
@ColtAllen ColtAllen deleted the ppc_plots branch November 28, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLV docs Improvements or additions to documentation enhancement New feature or request plots tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants