Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return 404 while request bad https path #1895

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

PikuZheng
Copy link
Contributor

在https get查询时路径若不为 /dns-query 时,返回404错误码 #1894

在https get查询时路径若不为 /dns-query 时,返回404错误码
@pymumu
Copy link
Owner

pymumu commented Jan 10, 2025

rfc有规定路径吗?
另外,测试失败了

@PikuZheng
Copy link
Contributor Author

rfc没有规定路径。
本修改是针对“客户端请求不符合设定路径”时的处理,rfc建议“处理的像个http服务器”,也就是路径不存在,也就是404。阿里采用了404应答。腾讯采用502应答。

测试不通过我不知道是什么原因。。。本地编译运行是成功的,修改也不涉及到测试失败的模块

@zxlhhyccc
Copy link
Contributor

测试不通过我不知道是什么原因。。。本地编译运行是成功的,修改也不涉及到测试失败的模块

[2025-01-09 14:09:06,227][DEBUG][      fast_ping.c:1453] ping 2001::, id = 2
[2025-01-09 14:09:06,227][DEBUG][      fast_ping.c:1227] from          2001::: error is Network is unreachable
[2025-01-09 14:09:06,227][DEBUG][      fast_ping.c:678 ] ping 2001:: end, id 2
[2025-01-09 14:09:06,227][ INFO][     dns_server.c:9344] IPV6 is not ready or speed check is disabled, disable IPV6 features
[2025-01-09 14:09:06,228][ INFO][     dns_client.c:1271] add server 127.0.0.1:62053, type: udp
[2025-01-09 14:09:06,228][ INFO][     dns_client.c:1271] add server 127.0.0.1:61053, type: udp
Error: 1-09 14:09:06,228][ERROR][      fast_ping.c:1019] create icmp socket failed, Operation not permitted
Error: 1-09 14:09:06,228][ERROR][      fast_ping.c:1019] create icmp socket failed, Operation not permitted
[2025-01-09 14:09:06,228][ INFO][      fast_ping.c:1041] create icmpv6 socket failed, Operation not permitted
[2025-01-09 14:09:06,228][ INFO][      fast_ping.c:1041] create icmpv6 socket failed, Operation not permitted
[2025-01-09 14:09:06,228][ INFO][      fast_ping.c:1041] create icmpv6 socket failed, Operation not permitted
[2025-01-09 14:09:06,228][ INFO][      fast_ping.c:1041] create icmpv6 socket failed, Operation not permitted
[2025-01-09 14:09:06,228][DEBUG][      fast_ping.c:1453] ping 2001::, id = 3

@pymumu pymumu merged commit b969ee6 into pymumu:master Jan 16, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants