Splice potential #121
Closed
Splice potential #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Along with a new minimization method (MINRES) which is much faster than the current CG method. Using MINRES is a must for potential splicing of large fields (scaling is much better).
|
Superseded by #127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a few functionalities, the biggest being the ability to splice the potential field instead of only the density field. Added an additional minimization technique (MINRES) which appears to be much faster than CG for both splicing types. To perform potential splicing, one should comment out the -DZELDOVICH_GRADIENT_FOURIER_SPACE flag in the Makefile, and enable MINRES (in the param file using set_minimization MINRES).