-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AHF halo ID fix #88
AHF halo ID fix #88
Commits on Dec 6, 2018
-
change raw_iter_rows for AHF stat file to return the file position as…
… the ID rather than the raw file ID to be consistent in meaning between MPI and non-MPI AHF versions. Also, remove spurious extra line in filename method.
Michael committedDec 6, 2018 Configuration menu - View commit details
-
Copy full SHA for 0f26bfd - Browse repository at this point
Copy the full SHA 0f26bfdView commit details
Commits on Dec 7, 2018
-
change the implementation of defining halo IDs from their position wi…
…thin the file rather than the value in the ID column of the file. Now each handler defines a flad when this needs to occur
Michael committedDec 7, 2018 Configuration menu - View commit details
-
Copy full SHA for 37e4626 - Browse repository at this point
Copy the full SHA 37e4626View commit details
Commits on Apr 8, 2019
-
add test for AHFStatFile class to ensure that the ID numbers are correct
Michael committedApr 8, 2019 Configuration menu - View commit details
-
Copy full SHA for 3179077 - Browse repository at this point
Copy the full SHA 3179077View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee51d3a - Browse repository at this point
Copy the full SHA ee51d3aView commit details
Commits on Apr 9, 2019
-
create separate test halo catalog with ID numbers more like the rando…
…m ones from MPI runs. Add a separate function to test this conversion specifically.
Michael committedApr 9, 2019 Configuration menu - View commit details
-
Copy full SHA for c29c405 - Browse repository at this point
Copy the full SHA c29c405View commit details
Commits on Feb 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 4502ee1 - Browse repository at this point
Copy the full SHA 4502ee1View commit details -
create new catalog_id property for halos to save the position within …
…the catalog of each halo. Include this in enumerate and iter_rows functions. Ensure that n_total is used to determine whether a halo satisfies min_halo_particles to ensure that ordering remains robust.
Configuration menu - View commit details
-
Copy full SHA for 134b570 - Browse repository at this point
Copy the full SHA 134b570View commit details
Commits on Feb 16, 2021
-
move counting for catalog_id calculation to iter_rows_raw and apply _…
…catalog_id_offset to these values. To remain consistent, children calculations will use only the raw halo ID number with no offset applied
Configuration menu - View commit details
-
Copy full SHA for 5299a33 - Browse repository at this point
Copy the full SHA 5299a33View commit details -
Configuration menu - View commit details
-
Copy full SHA for 92fed69 - Browse repository at this point
Copy the full SHA 92fed69View commit details -
update stat file tests to incorporate both catalog indices and finder…
… ID numbers. Fix the ID grp stat file reader to have catalog indices equal to the grp number so that these values can be used to access halo catalog correctly via pynbody.
Configuration menu - View commit details
-
Copy full SHA for 2f678a9 - Browse repository at this point
Copy the full SHA 2f678a9View commit details
Commits on Feb 22, 2021
-
update load_object function calls and ObjectSpecify constructors to i…
…nclude both finder_id and catalog_index as inputs
Configuration menu - View commit details
-
Copy full SHA for 317de9d - Browse repository at this point
Copy the full SHA 317de9dView commit details
Commits on Feb 24, 2021
-
propogate changes to halo objects to several test functions, yt and o…
…utput_testing input handlers, and Halo class functions
Configuration menu - View commit details
-
Copy full SHA for fba582b - Browse repository at this point
Copy the full SHA fba582bView commit details
Commits on Feb 26, 2021
-
fix inconsistent naming convention for catalog_index column.
Fix tracker and phantom halo initialization to include a catalog_index input Fix bh halo linking to now use catalog_index update ahf trees test to use catalog_index
Configuration menu - View commit details
-
Copy full SHA for c344e8e - Browse repository at this point
Copy the full SHA c344e8eView commit details -
-Update stat file importing to include additional output when reading…
… statfile -Update ahf_trees to use the raw finder_id values from tree data files -Perform correct halo object initialization in manager.py -If unset, make halo_number equal to the catalog index rather than finder_id -Update crosslink to utilize catalog_index rather than finder_id -Update property importer to expect correct number if outputs from stat file reader -Update object cache to use catalog_index rather than finder_id
Configuration menu - View commit details
-
Copy full SHA for ea7c175 - Browse repository at this point
Copy the full SHA ea7c175View commit details -
update two tests to expect correct results given changes in the code
make sure that the adapted enumerate returns the expected default result structure
Configuration menu - View commit details
-
Copy full SHA for 1d55bfb - Browse repository at this point
Copy the full SHA 1d55bfbView commit details
Commits on Mar 1, 2021
-
Have timestep cache create halo maps for both catalog_index and finde…
…r_id with an additional argument in resolve Include additional argument when dealing with timestep cache for Proxy Objects
Configuration menu - View commit details
-
Copy full SHA for c7547fc - Browse repository at this point
Copy the full SHA c7547fcView commit details -
update the yt halo reader to compare min_halo_particles with the tota…
…l particle count (Gas + Stars + DM) rather than just dark matter
Configuration menu - View commit details
-
Copy full SHA for c62b698 - Browse repository at this point
Copy the full SHA c62b698View commit details
Commits on Mar 2, 2021
-
add comments to explain various halo identifier columns (catalog_inde…
…x, finder_id, halo_number)
Configuration menu - View commit details
-
Copy full SHA for 1030ac3 - Browse repository at this point
Copy the full SHA 1030ac3View commit details -
remove superfluous checks when loading halo data which were attempting
to provide backwards compatibility but are now deprecated remove unneeded commented-out code re-write docstrings for iter_rows_raw functions to actually reflect the nature of the outputs.
Configuration menu - View commit details
-
Copy full SHA for d873acc - Browse repository at this point
Copy the full SHA d873accView commit details -
split the timestep cache resolve function into two separate functions…
… that identifies halos by either finder_id or catalog_index separately. Include this change in both the proxy object classes and property importer where appropriate.
Configuration menu - View commit details
-
Copy full SHA for 355e5df - Browse repository at this point
Copy the full SHA 355e5dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ff003a - Browse repository at this point
Copy the full SHA 8ff003aView commit details -
update docstring for iter_rows
make the AmigaIDLStatFile iter_rows_raw function more streamlined
Configuration menu - View commit details
-
Copy full SHA for f8eb973 - Browse repository at this point
Copy the full SHA f8eb973View commit details
Commits on Mar 17, 2021
-
change the name of the catalog_index halo attribute to finder_offset
and change all other variables and function names to be consistent with this change where appropriate
Configuration menu - View commit details
-
Copy full SHA for aacf2ee - Browse repository at this point
Copy the full SHA aacf2eeView commit details