-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add FigureCanvasWasm.destroy() method so that user can call pyplot.close() method to delete previous divs #55
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #55 +/- ##
======================================
Coverage ? 0.00%
======================================
Files ? 4
Lines ? 671
Branches ? 0
======================================
Hits ? 0
Misses ? 671
Partials ? 0 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yu0A for working on this!
Please add some tests so we can make sure this works as expected. I think you should test that the intended HTML elements are deleted, that the behavior is idempotent (calling show and destroy multiple times does not break matplotlib), and that it is compatible with pyodideMplTarget.
This very simple test would be a good starting point to take a look.
Also, please
- update the PR title to be a bit more descriptive, we can search for it later.
- update the CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. It seems like CI was failing because of outdated package versions in CI. I updated it in #56, so please merge the main branch in your PR and see if it works.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Released 0.2.2 including this. |
Thanks @yu0A! |
You're welcome. |
No description provided.