Bump Pyodide version, Python version, and other cleanups #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agriyakhetarpal
changed the title
Merged
|
Most of the failing tests are caused by timeouts, are there any hints as to how I can debug these in more detail? |
|
On the contrary, Firefox is passing in #62—even a test that we have currently xfailed ( |
|
Could you try chrome < 126? IIRC there was an regression in chrome 126 which broke the test (I think it was related to JSPI). Micropip also pins chrome version https://github.com/pyodide/micropip/blob/91773c4536b3ced328b052185b3756b6d64bede7/.github/workflows/main.yml#L23-L24 |
|
You'll also need to update the pyodide-actions/install-browser version to v2 to make the version parameter work correctly. |
ryanking13
approved these changes
Nov 29, 2024
Co-Authored-By: Gyeongjae Choi <[email protected]>
|
Yes, looks like this is working, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #60. We can now use Python 3.12 and later for building for for Mypy checks;
setuptoolsinjectswheelwhen building wheels, sowheelis not required as a build-time dependency anymore; and some bumps to versions for a few GitHub Actions.