Add testing on macOS #63
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanking13
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Thanks! When I was initially working on pyodide-actions, the macos + safari combination was the only one I was interested in, so I didn't really care about the macos + [chrome, firefox] combination. But if you think it is useful to support those combinations, feel free to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of opening, this is going to fail as it did in this workflow run, but it looks like an easy fix in https://github.com/pyodide/pyodide-actions/. This does not need to block a release, and I shall test out a patch for the action in my fork of it first.