-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Action CI file #4
base: main
Are you sure you want to change the base?
Conversation
c6cd7f4
to
9d11618
Compare
9d11618
to
72d6ca7
Compare
@rth could you help me to change the default branch to Also, do you think installing --
-- |
Sure, done. The issue was that there were both main and master (default) branches that where identical. So I deleted main then [renamed master to main](could you help me to change the default branch to main?). You just need to make the change locally as well afterwards, Another alternative for future PRs, just fork this repo to you account (which is a better in any case) and the branches will be correct |
Feel free to open a PR of you think so.
I think a better way would be to build and deploy the NPM package for each commit on main, that way you could install it from say
As far as I understand that's the bundler output: are those usually included in the uploaded npm package? If you find that it should be included, of course, feel free to open a PR. |
It is a good idea. I did not use
It depends on the usages. From my recent study, I saw some bunder will out a) Some use Node.js conditional export (in package.json) with
I think this is for the users who do not set "type": "module" (even without a bunder/babel) and they rely on file extensions to tell whether a used module is ESModule. As I remember, neither "Parcel/Rollup" uses b) Some use "module" filed in
But for Rollup case, I'm not sure whether the |
ref: #3
todo:
make build/pyodide.js
ormake src/js/pyproxy.gen.js
) sincepyodide.js
needs the generatedpyproxy.gen.js
forimport "./pyproxy.gen.js"
.