Pin PyO3 to <0.23.4 #5323
Closed
Pin PyO3 to <0.23.4 #5323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
approved these changes
Jan 13, 2025
|
Uh oh, the pin didn't work it still downloaded pyo3-0.23.4 |
|
Probably we need pyodide/pyodide-build#49 (comment)? Otherwise, we can set I think the latter is the better option, as pyodide/pyodide-build#49 only applies to in-tree build. |
|
Can you make a PR to fix it @ryanking13? |
|
Or maybe we should stop being obstinate and just bump the rust version... |
Sure, let me try. |
|
Thanks! |
|
Oh, I just realized that pyo3 is not a Python package, but it is a rust package 😅. Anyway, let me try to fix this. |
|
Yes, that looks like a better solution. Thanks, @ryanking13! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As suggested in #5321 (comment), to fix failing builds for PyO3.
Checklists
N/A