-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tool recommendations #1474
Conversation
@chrysle Thanks for reviewing! I've addressed your comments, sometimes with slightly different wordings. |
I believe I've addressed all review comments. There were many reviews and it's not clear to me whether reviewers are now OK with the PR or just didn't have the time to take another look. |
I didn't have time, but I hope to find some. |
Co-authored-by: Anderson Bravalheri <[email protected]>
Co-authored-by: Anderson Bravalheri <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
29ffb95
to
8bd6676
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked all the threads as resolved as there doesn't seem to be anything more actionable or blocking.
The CI seems to be failing for an unrelated reason: (tutorials/installing-packages: line 444) broken https://stackoverflow.com/a/14638025 - 403 Client Error: Forbidden for url: https://stackoverflow.com/a/14638025 The deps don't seem to differ compared to |
@webknjaz Maybe for CI, we change the SO link in the source to: https://stackoverflow.com/questions/14637979/how-to-permanently-set-path-on-linux-unix/14638025#14638025 It's where the CI link actually redirects if entered in the browser. |
@willingc that might work but needs checking. It should be done in a separate PR, though. An alternative would be adding a pattern to |
@jeanas while that's being sorted out, what do you think about possibly linking https://pip.pypa.io/en/latest/topics/workflow/ / pypa/pip#12503 in follow-ups? Not sure if it'd go in this specific doc, though. |
This is my proposal to address #1468.
Fixes #1468
📚 Documentation preview 📚: https://python-packaging-user-guide--1474.org.readthedocs.build/en/1474/guides/tool-recommendations/