Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide on packaging command-line tooling #1553

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

chrysle
Copy link
Contributor

@chrysle chrysle commented May 26, 2024

Part of #615.

Declaring this blocked until a new version of pipx is released, as the part with the pipx run entry point won't work as expected right now. Fixed in fresh-off-the-press pipx 1.6.0. Review feedback is much welcomed, of course!


📚 Documentation preview 📚: https://python-packaging-user-guide--1553.org.readthedocs.build/en/1553/

Copy link
Member

@jaraco jaraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. Overall, looks good to me. I've made a few suggestions for your consideration.

source/guides/creating-command-line-tools.rst Outdated Show resolved Hide resolved
source/guides/creating-command-line-tools.rst Outdated Show resolved Hide resolved
source/guides/creating-command-line-tools.rst Outdated Show resolved Hide resolved
source/guides/creating-command-line-tools.rst Outdated Show resolved Hide resolved
source/guides/creating-command-line-tools.rst Outdated Show resolved Hide resolved
source/guides/creating-command-line-tools.rst Outdated Show resolved Hide resolved
source/guides/creating-command-line-tools.rst Outdated Show resolved Hide resolved
source/guides/creating-command-line-tools.rst Outdated Show resolved Hide resolved
source/guides/creating-command-line-tools.rst Outdated Show resolved Hide resolved
source/guides/creating-command-line-tools.rst Show resolved Hide resolved
@chrysle
Copy link
Contributor Author

chrysle commented Jun 22, 2024

Thanks for your comments; I've been quite busy lately, but should be able to take a thorough look tomorrow.

@chrysle chrysle force-pushed the add-guide-packaging-command-line-tooling branch from d3e83ff to ce63bfb Compare June 24, 2024 15:15
@chrysle chrysle requested a review from jaraco June 25, 2024 20:05
chrysle and others added 3 commits July 29, 2024 10:56
Make the guide more easily comprehensible, mention difference between
src and flat layout concerning `runpy` behaviour, mention typer CLI
parser, tighten language

Co-authored-by: Jason R. Coombs <[email protected]>
@chrysle chrysle force-pushed the add-guide-packaging-command-line-tooling branch from d4ba888 to 2d7be49 Compare July 29, 2024 08:56
@chrysle chrysle enabled auto-merge July 29, 2024 08:56
@chrysle chrysle added this pull request to the merge queue Jul 29, 2024
Merged via the queue into pypa:main with commit 9788da1 Jul 29, 2024
5 checks passed
@chrysle chrysle deleted the add-guide-packaging-command-line-tooling branch July 29, 2024 09:00
@chrysle
Copy link
Contributor Author

chrysle commented Jul 29, 2024

Thank you, @jaraco!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants