Skip to content

Commit

Permalink
Postpone removal of non-bare names in egg fragment to 25.1
Browse files Browse the repository at this point in the history
The only way for editable VCS URL installs to request an extra is to
place them in the egg fragment. Of course, this is undocumented
and deprecated behaviour, but we should ensure
`pip install -e name[extra] @ VCS_URL` actually works before breaking
our users.
  • Loading branch information
ichard26 committed Jan 12, 2025
1 parent 1452429 commit acbbe28
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion src/pip/_internal/cli/base_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ def _main(self, args: List[str]) -> int:

if options.no_python_version_warning:
deprecated(
reason="--no-python-verison-warning is deprecated.",
reason="--no-python-version-warning is deprecated.",
replacement="to remove the flag as it's a no-op",
gone_in="25.1",
issue=13154,
Expand Down
6 changes: 3 additions & 3 deletions src/pip/_internal/models/link.py
Original file line number Diff line number Diff line change
Expand Up @@ -466,10 +466,10 @@ def _egg_fragment(self) -> Optional[str]:
project_name = match.group(1)
if not self._project_name_re.match(project_name):
deprecated(
reason=f"{self} contains an egg fragment with a non-PEP 508 name",
reason=f"{self} contains an egg fragment with a non-PEP 508 name.",
replacement="to use the req @ url syntax, and remove the egg fragment",
gone_in="25.0",
issue=11617,
gone_in="25.1",
issue=13157,
)

return project_name
Expand Down

0 comments on commit acbbe28

Please sign in to comment.