Skip to content

Commit

Permalink
make 1 the default value of the parallel-downloads arguement
Browse files Browse the repository at this point in the history
  • Loading branch information
NeilBotelho committed Mar 6, 2024
1 parent fa268ae commit e754fd6
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 13 deletions.
2 changes: 1 addition & 1 deletion src/pip/_internal/cli/cmdoptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ def _handle_no_cache_dir(
dest="parallel_downloads",
type="int",
metavar="n",
default=None,
default=1,
help=(
"Use upto <n> threads to download packages in parallel."
"<n> must be greater than 0"
Expand Down
6 changes: 1 addition & 5 deletions src/pip/_internal/cli/req_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -118,18 +118,14 @@ def _build_session(
ssl_context = None
else:
ssl_context = None
if "parallel_downloads" in options.__dict__:
parallel_downloads = options.parallel_downloads
else:
parallel_downloads = None

session = PipSession(
cache=os.path.join(cache_dir, "http-v2") if cache_dir else None,
retries=retries if retries is not None else options.retries,
trusted_hosts=options.trusted_hosts,
index_urls=self._get_index_urls(options),
ssl_context=ssl_context,
parallel_downloads=parallel_downloads,
parallel_downloads=options.parallel_downloads,
)

# Handle custom ca-bundles from the user
Expand Down
4 changes: 1 addition & 3 deletions src/pip/_internal/commands/download.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,7 @@ def add_options(self) -> None:

@with_cleanup
def run(self, options: Values, args: List[str]) -> int:
if (options.parallel_downloads is not None) and (
options.parallel_downloads < 1
):
if options.parallel_downloads < 1:
raise CommandError("Value of '--parallel-downloads' must be greater than 0")

options.ignore_installed = True
Expand Down
6 changes: 2 additions & 4 deletions src/pip/_internal/network/session.py
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ def __init__(
trusted_hosts: Sequence[str] = (),
index_urls: Optional[List[str]] = None,
ssl_context: Optional["SSLContext"] = None,
parallel_downloads: Optional[int] = None,
parallel_downloads: int = 1,
**kwargs: Any,
) -> None:
"""
Expand Down Expand Up @@ -367,9 +367,7 @@ def __init__(
# pip._internal.network.BatchDownloader and to set pool_connection in
# the HTTPAdapter to prevent connection pool from hitting the default(10)
# limit and throwing 'Connection pool is full' warnings
self.parallel_downloads = (
parallel_downloads if (parallel_downloads is not None) else 1
)
self.parallel_downloads = parallel_downloads
pool_maxsize = max(self.parallel_downloads, 10)
# Our Insecure HTTPAdapter disables HTTPS validation. It does not
# support caching so we'll use it for all http:// URLs.
Expand Down

0 comments on commit e754fd6

Please sign in to comment.