Cache the user agent #12563
Merged
Cache the user agent #12563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pradyunsg
added
the
skip news
pradyunsg
force-pushed
the
cache-user-agent
branch
from
efed441 to
217006b
Compare
pfmoore
approved these changes
Mar 10, 2024
|
lol unit tests failing because they expect to be able to change the environment and see changes in the function result. I'm inclined to think the benefit of caching isn't sufficient to bother if we need to fix the tests, but it's your call as you'll be doing the work 😉 |
This does not need to be computed multiple times in the same process.
pradyunsg
force-pushed
the
cache-user-agent
branch
from
217006b to
4f2ccfc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not need to be computed multiple times in the same process.