Draft: Fix warning message for missing METADATA file #13119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pypa#12446 Update the warning message for missing `METADATA` file in dist-info directories. * Update the warning message in `src/pip/_internal/metadata/importlib/_compat.py` to differentiate between a missing `METADATA` file and other metadata issues. * Add a check for the existence of the `METADATA` file in the `get_dist_canonical_name` function. * Add a test case in `tests/functional/test_list.py` to verify the new warning message for a missing `METADATA` file. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/pypa/pip/issues/12446?shareId=XXXX-XXXX-XXXX-XXXX).
anuk909
changed the title
* **`src/pip/_internal/metadata/importlib/_compat.py`** - Add `joinpath` method to `BasePath` class. * **`news/12446.bugfix.rst`** - Document changes made to fix the issue.
anuk909
commented
Dec 18, 2024
| @@ -100,8 +101,8 @@ class Distribution(BaseDistribution): | |||
| def __init__( | |||
| self, | |||
| dist: importlib.metadata.Distribution, | |||
| info_location: Optional[BasePath], | |||
| installed_location: Optional[BasePath], | |||
| info_location: Optional[Union[BasePath, pathlib.PurePosixPath]], | |||
There was a problem hiding this comment.
PurePosixPath doesn't have exists and I didn't find more elegant way to solve it
anuk909
changed the title
anuk909
changed the title
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12446
Update the warning message for missing
METADATAfile in dist-info directories.src/pip/_internal/metadata/importlib/_compat.pyto differentiate between a missingMETADATAfile and other metadata issues.METADATAfile in theget_dist_canonical_namefunction.tests/functional/test_list.pyto verify the new warning message for a missingMETADATAfile.