Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: email formatting #87

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

rooterkyberian
Copy link
Contributor

No description provided.

@henryiii
Copy link
Collaborator

henryiii commented Mar 19, 2024

This also removes names if they don't have an email attached, while the original code puts the name in with empty email. Ahh, sorry, there's an if _email at the end, I don't seem to be able to read a diff (at least while feeding a baby).

@henryiii
Copy link
Collaborator

henryiii commented Mar 19, 2024

Looking at https://packaging.python.org/en/latest/specifications/pyproject-toml/#authors-maintainers, I think the new behavior is likely correct, though I think it might not handle missing name correctly still. No, formataddr does this correctly: email.utils.formataddr(("", "[email protected]")) returns [email protected].

@henryiii henryiii force-pushed the fix_emails_formatting branch from 3cc5831 to 6702287 Compare March 19, 2024 07:38
@henryiii henryiii mentioned this pull request Mar 19, 2024
@rooterkyberian
Copy link
Contributor Author

@henryiii anything I can help with to get it merged?

@henryiii
Copy link
Collaborator

I'm waiting on pre-commit to be reactivated (#90) then will merge this.

@henryiii henryiii force-pushed the fix_emails_formatting branch from 6702287 to 3bda205 Compare March 25, 2024 19:38
@henryiii henryiii changed the title fix email formatting fix: email formatting Mar 25, 2024
@henryiii henryiii merged commit d263e29 into pypa:main Mar 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants