feat: support metadata 2.1-2.3 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/feat/metadata
branch
from
d7a3cb5 to
8e96749
Compare
frostming
approved these changes
Mar 25, 2024
dnicolodi
reviewed
Mar 25, 2024
|
I think I slightly misunderstood Metadata 2.3. I believe all extras before 2.3 are (now) supposed to be normalized, and 2.3 restricts the valid set to normalized extras only. Currently, we are producing: Which is incorrect, these don't match. It's caused by I'm not sure of my reading of the PEP and guidelines, but happy to be corrected if wrong! |
|
@frostming I re-requested a review just to make sure you were okay with the extra normalization always occurring. |
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/metadata
branch
from
48ec6b9 to
4286944
Compare
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
frostming
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on supporting metadata 2.3 and allowing a backend to choose what version they want.
In draft until I add tests.