Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce ruff/refurb rules (FURB) #4386

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

DimitriPapadopoulos
Copy link
Contributor

Summary of changes

Enforce ruff/refurb rules (FURB).

Follow-up of #4172.

Pull Request Checklist

@Avasam Avasam mentioned this pull request Jun 17, 2024
2 tasks
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review June 28, 2024 17:40
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as draft June 28, 2024 17:42
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review June 28, 2024 18:08
@DimitriPapadopoulos DimitriPapadopoulos changed the title Enforce ruff/refurb rules Enforce ruff/refurb rules (FURB) Jun 28, 2024
@Avasam
Copy link
Contributor

Avasam commented Aug 19, 2024

Looks like you're missing imports for operator

@DimitriPapadopoulos
Copy link
Contributor Author

I think I mistakenly removed the imports while rebasing. Should be fixed now.

FURB110 Replace ternary `if` expression with `or` operator
FURB118 Use `operator.itemgetter(0)` instead of defining a lambda
FURB142 Use of `set.add()` in a for loop
FURB167 Use of regular expression alias `re.I`
FURB167 Use of regular expression alias `re.M`
FURB167 Use of regular expression alias `re.S`
FURB167 Use of regular expression alias `re.X`
FURB192 Prefer `max` over `sorted()` to compute the maximum value in a sequence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants