Disable and revert unpacked-list-comprehension (UP027)
#4558
+6
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
force-pushed
the
disable-UP027
branch
2 times, most recently
from
27bf87d
to
42a5eee
Compare
Avasam
commented
Aug 12, 2024
| self.warn, | ||
| "Couldn't find index page for %r (maybe misspelled?)", | ||
| ) | ||
| meth, msg = self.warn, "Couldn't find index page for %r (maybe misspelled?)" |
There was a problem hiding this comment.
Not strictly related to unpacked-list-comprehension (UP027), but I found this whilst looking for ,.*? = \( so I figured I might make it cleaner too whilst I saw it.
Avasam
force-pushed
the
disable-UP027
branch
from
45e995e
to
644c69d
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
In astral-sh/ruff#12754 it was found that the original pyupgrade rule
unpacked-list-comprehension (UP027)is based on lacks justification and is actually slower in cases relevant to unpacking (ie: small sizes). The rule is deprecated in astral-sh/ruff#12843 for Ruff 0.6This PR disables the rule now before there's any usage of it. I also searched for
,.*? = \(to find any code that would've triggered it and revert.Pull Request Checklist
newsfragments/.(See documentation for details)