upload: add connection exceptions to upload retry protocol #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sigmavirus24
requested changes
Nov 29, 2023
|
Sorry, meant to draft this from the start, PR was meant as a rough proposal and there a few things that are still unclear:
will add a test and a few improvements asap. |
ashwoods
commented
Nov 29, 2023
| @@ -183,21 +183,31 @@ def upload( | |||
| ) -> requests.Response: | |||
| number_of_redirects = 0 | |||
There was a problem hiding this comment.
should I rename to retries? redirects aren't really handled here.
ashwoods
commented
Nov 29, 2023
| return resp | ||
|
|
||
| return resp | ||
| if resp.status_code == requests.codes.OK: |
There was a problem hiding this comment.
slighlty redundant, but can leave for clarity. Should add a continue to the retry if clause.
There was a problem hiding this comment.
Additionally, as the _upload function calls on POST without redirects, we aren't really handling anywhere (they are simply returned)
loewenheim
approved these changes
Nov 29, 2023
|
This doesn't merge cleanly, doesn't solve the problem at the right layer, and it re-invents a wheel for which there are many good solutions. I'm closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses our intermittent upload issues as described that #1017 was initially trying to address.
Although we are mainly running into "connection reset by peer" exceptions, I've added connection timeouts, and I'd consider adding a sleep between retries.