-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: skip upload for sonatype nexus collision #1221
base: main
Are you sure you want to change the base?
feat: skip upload for sonatype nexus collision #1221
Conversation
Thanks for the PR @jafournier. Two quick questions:
|
f0eb0f3
to
05c096b
Compare
05c096b
to
aa27805
Compare
Thanks for your answer @woodruffw! Indeed the two are the same, consequently I merged the two lines. |
Got it, thanks for checking! This LGTM overall; could you please create a changelog entry for your changes as well? I think this could go under either Instructions for the changelog are here: https://twine.readthedocs.io/en/stable/contributing.html#changelog-entries |
sure, done. |
Yeah so someone was going to fix this in Nexus itself. There is at least one closed issue about this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nexus was supposed to fix this breakage and there's a closed twine issue about that exact topic
Hello @sigmavirus24, are you refering to #1044 ? Though I theoretically agree that nexus should homogenize it's error messages and stop changing them, what are the chances the issue would be resolved this coming year in practice? |
@jafournier fixing things here is the path to increasing curb and complexity. Frankly the right fix here is limiting the skip existing feature to indices that actually fully implement the API(s) we expect as we did with trusted publishing and removing string checking hacks. |
Context:
We want to use the
--skip-existing
option with Sonatype Nexus' pypi.However when package already exists, Sonatype Nexus is delivering a 400 reponse with a content not handled yet in the code.
The purpose of this PR is to handle such contents.