feat: follow mx records back to pointers #16814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the event that the MX domain returned is not on the list, but the IP address of the MX server is the same as another one on our list, resolve those records back to their registered domains to compare. Signed-off-by: Mike Fiedler <[email protected]>
Signed-off-by: Mike Fiedler <[email protected]>
Signed-off-by: Mike Fiedler <[email protected]>
miketheman
force-pushed
the
miketheman/mx-to-ptr-and-back
branch
from
ab96fc8
to
c5fa936
Compare
ewdurbin
approved these changes
Oct 10, 2024
| # Resolve the returned MX domain's IP address to a PTR record, to a domain | ||
| all_mx_domains = set() | ||
| for mx_domain in mx_domains: | ||
| with contextlib.suppress(dns.resolver.NoAnswer, dns.resolver.NXDOMAIN): |
There was a problem hiding this comment.
Will this cover slow/broken responses? Do we need to wrap this in some kind of timeout?
There was a problem hiding this comment.
If I'm reading the source of dnspython correctly, when it's initialized it sets a default timeout of 2 seconds. https://github.com/rthalley/dnspython/blob/889385e71021f53e1dc4f117d92aed66bb90d087/dns/resolver.py#L958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the event that the MX domain returned is not on the list,
but the IP address of the MX server is the same as another one on our
list, resolve those records back to their registered domains to compare.
Signed-off-by: Mike Fiedler [email protected]