-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds localization column in the alerts table #267
Conversation
Nice of you to open a PR 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this addition @frgfm ! We initially thought this was urgent but in the end I propose we take the time to fix the issues with the CI and we deploy a data model consistent with all the other tables and classes:
- introduce a class Bbox, ROI / RegionOfInterest or equivalent with
x0, y0, x1, y1, confidence
, and a list of those toAlertIn
, instead of strings - add a table with the info above and
alert_id
, to allow multiple bboxes for each alert
I also managed to run the API and the tests locally. My attempts with the CI did not work either so we can try to apply the various changes one by one in another PR:
- python 3.8 -> 3.9
- pydantic 1.10 -> 2
- code-quality fixes
- postgres 12 -> 15
- changes in docker-compose, including health-checks
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
==========================================
- Coverage 95.18% 94.71% -0.47%
==========================================
Files 66 66
Lines 1577 1590 +13
==========================================
+ Hits 1501 1506 +5
- Misses 76 84 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This PR introduces the following modifications:
localization
field in the alerts table. Meant to be used as a JSON dump of a list of bounding boxesHere is the new database UML:
cc @MateoLostanlen