ENH: Graph.eliminate_zeros, refactor isolates #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinfleis
commented
Nov 9, 2023
| # since not all zeros are necessarily isolates, do the focal == neighbor check | ||
| return nulls[nulls.index == nulls.neighbor].index.unique() | ||
| return ( | ||
| nulls[nulls.index.codes[0] == nulls.index.codes[1]] |
There was a problem hiding this comment.
This is indeed faster than the original solution. On exploded geoda tampa1 dataset and basic contiguity 84.8 µs ± 5.65 µs vs 253 µs ± 6.75 µs.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #634 +/- ##
=====================================
Coverage 84.7% 84.8%
=====================================
Files 139 139
Lines 14869 14880 +11
=====================================
+ Hits 12601 12612 +11
Misses 2268 2268
|
jGaboardi
approved these changes
Nov 9, 2023
martinfleis
commented
Nov 10, 2023
sjsrey
approved these changes
Nov 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #633