Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix offset for Poisson GWR #102

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix offset for Poisson GWR #102

wants to merge 2 commits into from

Conversation

mcvholloway
Copy link

Resolves #101

Ziqi-Li
Ziqi-Li requested changes Mar 9, 2022
View reviewed changes
Copy link
Member

@Ziqi-Li Ziqi-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, indeed the summary file does not output correctly when there is an offset.

mgwr/gwr.py
@@ -210,7 +210,7 @@ def __init__(self, coords, y, X, bw, family=Gaussian(), offset=None,
"""
Initialize class
"""
GLM.__init__(self, y, X, family, constant=constant)
GLM.__init__(self, y, X, family, constant=constant, offset=offset)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not needed as the offset was included in Line 220 to Line 223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ziqi-Li Ziqi-Li Ziqi-Li requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offset is not passed to GWR
2 participants
@mcvholloway @Ziqi-Li