Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add Streetscape class #658

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

martinfleis
Copy link
Member

This adds code implemented by Alessandro Araldi and his team, wrapped into a user friendly API that can be accessed from momepy. It essentially enables analysis of streetscape outlined in 10.1111/gean.12416.

The code is sloooooooooooooooooooooooo... ah... oooooooooooooooow. But it runs. Anyone is happy to refactor. I have picked some low hanging fruits but it is in a dire need of complete refactoring for which I do not have a capacity. It should follow the logic we have in street_profile and its performance but is now several orders of magnitude slower. But hey, it works and allows reproducible research. so yay!

@martinfleis
Copy link
Member Author

One thing to note - I have added plots from cadastre and DTM from Prague's data portal to the bubenec.gpkg.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 97.62188% with 20 lines in your changes missing coverage. Please review.

Project coverage is 98.0%. Comparing base (4037c70) to head (df3437f).
Report is 88 commits behind head on main.

Files with missing lines Patch % Lines
momepy/streetscape.py 97.5% 20 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #658     +/-   ##
=======================================
+ Coverage   97.4%   98.0%   +0.6%     
=======================================
  Files         26      40     +14     
  Lines       4328    7157   +2829     
=======================================
+ Hits        4214    7013   +2799     
- Misses       114     144     +30     
Files with missing lines Coverage Δ
momepy/__init__.py 100.0% <100.0%> (ø)
momepy/tests/test_streetscape.py 100.0% <100.0%> (ø)
momepy/streetscape.py 97.5% <97.5%> (ø)

@martinfleis
Copy link
Member Author

@jGaboardi FYI, I am not expecting you to review this.

@jGaboardi
Copy link
Member

@jGaboardi FYI, I am not expecting you to review this.

It is very large. LOL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants