Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove zip(strict=True) in k-nearest p-median #403

Merged
merged 4 commits into from
Oct 15, 2023
Merged

remove zip(strict=True) in k-nearest p-median #403

merged 4 commits into from
Oct 15, 2023

Conversation

jGaboardi
Copy link
Member

This PR resolves #402 and runs pmedian.ipynb for output.

@jGaboardi jGaboardi added bug Something isn't working locate labels Oct 14, 2023
@jGaboardi jGaboardi self-assigned this Oct 14, 2023
@jGaboardi
Copy link
Member Author

Can confirm that all tests are passing/failing as they should (considering #386).

martinfleis
martinfleis approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@martinfleis martinfleis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jGaboardi jGaboardi merged commit 889a50d into pysal:main Oct 15, 2023
2 of 8 checks passed
@jGaboardi jGaboardi deleted the pmedian_bug branch October 15, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinfleis martinfleis martinfleis approved these changes

@gegen07 gegen07 Awaiting requested review from gegen07

Assignees

@jGaboardi jGaboardi

Labels
bug Something isn't working locate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

k-nearest pmedian failures due to zip(strict=True)
2 participants
@jGaboardi @martinfleis