Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add copy url to clipboard #1393

Closed
wants to merge 4 commits into from
Closed

Conversation

NekOware
Copy link

@NekOware NekOware commented Aug 7, 2024

Add a thing to copy the episode url to clipboard

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

Syncplay was a little odd so I just thought it'd be easier to have the episode URL copied to the clipboard and then pasted to syncplay instead of rejoining the instance 200 times just while watching one piece for example.
I've just checked the applicable below.

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

Add a thing to copy the episode url to clipboard
dependencies -> +clipboooard
CLIPBOOOOOOAAAARRDD
help and version bump forgor
@port19x
Copy link
Collaborator

port19x commented Aug 8, 2024

This seems like a poorly thought out patch.
On linux and mac it's possible to copy to the clipboard without a third-party depedency.
I'm not sure about windows, but that should work as well.

I used syncplay yesterday and it works fine.
If you're referring to watching multiple episodes in one sitting, range selection should be enough.

I'm sure there is a quality of life patch you could do to add all episodes in the range to a temp file and then use that as the syncplay playlist.
That way you can still contribute

@port19x
Copy link
Collaborator

port19x commented Aug 8, 2024

Nice pfp btw

@port19x
Copy link
Collaborator

port19x commented Aug 8, 2024

I'm closing this PR, but invite you to open another one to improve our syncthing integration

@port19x port19x closed this Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants