-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add variable fitler to snapshot #1090
Open
leowrites
wants to merge
3
commits into
pyta-uoft:master
Choose a base branch
from
leowrites:add-variable-fitler-to-snapshot
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+157
−21
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -37,11 +37,25 @@ def get_filtered_global_variables(frame: FrameType) -> dict: | |
return {"__main__": true_global_vars} | ||
|
||
|
||
def get_filtered_local_variables(frame, exclude_vars: Optional[Iterable[str | re.Pattern]]) -> dict: | ||
""" | ||
Helper function for filtering local variables in a frame. | ||
""" | ||
if exclude_vars: | ||
return { | ||
var: frame.f_locals[var] | ||
for var in frame.f_locals | ||
if not any(re.search(regex, var) for regex in exclude_vars) | ||
} | ||
return frame.f_locals | ||
|
||
|
||
def snapshot( | ||
save: bool = False, | ||
memory_viz_args: Optional[list[str]] = None, | ||
memory_viz_version: str = "latest", | ||
include: Optional[Iterable[str | re.Pattern]] = None, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think you're absolutely correct to rename this to |
||
exclude_vars: Optional[Iterable[str | re.Pattern]] = None, | ||
): | ||
"""Capture a snapshot of local variables from the current and outer stack frames | ||
where the 'snapshot' function is called. Returns a list of dictionaries, | ||
|
@@ -56,14 +70,17 @@ def snapshot( | |
include can be used to specify a collection of function names, either as strings or regular expressions, | ||
whose variables will be captured. By default, all variables in all functions will be captured if no `include` | ||
argument is provided. | ||
exclude_vars can be used to specify a collection of variable names, either as strings or regular expressions, | ||
that will be excluded from the snapshot. By default, all variables will be captured if no `exclude_vars` is provided. | ||
""" | ||
variables = [] | ||
frame = inspect.currentframe().f_back | ||
|
||
while frame: | ||
if include is None or any(re.search(regex, frame.f_code.co_name) for regex in include): | ||
if frame.f_code.co_name != "<module>": | ||
variables.append({frame.f_code.co_name: frame.f_locals}) | ||
local_vars = get_filtered_local_variables(frame, exclude_vars) | ||
variables.append({frame.f_code.co_name: local_vars}) | ||
else: | ||
global_vars = get_filtered_global_variables(frame) | ||
variables.append(global_vars) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure to include a type annotation for
frame
as well