testing: some cleanups #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bluetech
force-pushed
the
testing-rm-py
branch
6 times, most recently
from
62b546f
to
275bd60
Compare
|
i'tll be a bit before i can review, this may conflict with #168 |
Fix:
```
testing/test_basics.py::TestPureChannel::test_factory_create[thread]
testing/test_basics.py::TestPureChannel::test_factory_getitem[thread]
testing/test_basics.py::TestPureChannel::test_channel_timeouterror[thread]
testing/test_basics.py::TestPureChannel::test_channel_makefile_incompatmode[thread]
/home/ran/src/execnet/.tox/py310/lib/python3.10/site-packages/_pytest/unraisableexception.py:78: PytestUnraisableExceptionWarning: Exception ignored in: <function Channel.__del__ at 0x7fcb5b6a13f0>
Traceback (most recent call last):
File "/home/ran/src/execnet/execnet/gateway_base.py", line 605, in __del__
self.gateway._send(msgcode, self.id)
AttributeError: 'Gateway' object has no attribute '_send'. Did you mean: '_send_'?
```
`startswith` is incorrect for paths in general, e.g. doesn't handle Windows extended-length paths and other such. The particular code here also wasn't careful about `/a/bc` not being relative to `/a/b`.
Use modern alternatives instead.
|
Finally it passes! There was major headache on the rsync tests on windows. Because @RonnyPfannschmidt I didn't notice #168 regrettably. Some of the changes are similar, I'll try to do the rebase and see the differences. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly removing use of
pyandtestdir- see commits.