-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add specific tests for PurePosixPath and PureWindowsPath #1066
Conversation
Thanks - I see the failing tests... I will have a look over the weekend, unless you are going to fix it yourself :) |
7ac7064
to
dbbecf9
Compare
@lengau: I added a commit with a fix for the reserved names to this PR (didn't want to copy the tests, or push the fix before the tests). I wrote a spin-off issue for the Please check if that works for you. |
dbbecf9
to
4de825a
Compare
- had been only patched for pathlib.Path - avoid possible recursion in PurePath.joinpath - fixes pytest-dev#1067
4de825a
to
0cbc2f3
Compare
Ok, turned out the I'm planning to make a new release with these fixes (and with the official 3.13 support that I also added, as Python 3.13 was released today) soon - please check if this works for you. |
@mrbean-bremen thanks for doing this! I was meaning to get to it this weekend but ended up being busy with other things. These fixes work for me on my Linux machine. |
Sounds familiar...
Ok, I'm going to merge this and make a new release tonight - thanks! |
Describe the changes
Adds tests specific to PurePosixPath and PureWindowsPath to catch issues like #1065
Tasks