New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FakeIOModule.open argument renaming: file_name to file #471

Merged

mrbean-bremen merged 1 commit into pytest-dev:master from kmerenkov:patch-1

Mar 13, 2019

Contributor

kmerenkov commented Mar 13, 2019 •

edited

Loading

Changed argument name in FakeIOModule.open from file_name to file.
It makes pyfakefs compatible with the library atomicwrites that uses kwargs to pass arguments to io.open function.
See https://github.com/untitaker/python-atomicwrites/blob/890e7aed4a1fd3b3724dc64503757617996c3978/atomicwrites/__init__.py#L180

In python documentation argument is also named file:
py3: https://docs.python.org/3/library/functions.html#open
py2: https://docs.python.org/2.7/library/io.html#io.open


          FakeIOModule.open argument renaming: file_name to file

915d8e6

Changed attribute name in `FakeIOModule.open` from `file_name` to `file`.
It makes pyfakefs compatible with the library atomicwrites that uses `kwargs` to pass attributes to `io.open` function.
See https://github.com/untitaker/python-atomicwrites/blob/890e7aed4a1fd3b3724dc64503757617996c3978/atomicwrites/__init__.py#L180

In python documentation argument is also named `file`:
py3: https://docs.python.org/3/library/functions.html#open
py2: https://docs.python.org/2.7/library/io.html#io.open

Member

mrbean-bremen commented Mar 13, 2019

Thanks - this makes sense!

mrbean-bremen merged commit 3465cc1 into pytest-dev:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet