Add setUpClassPyfakefs convenience method #758
Conversation
- only available from Python 3.8 onwards - also add class-scoped 'fs_class' fixture - handle patcher for doc tests separately
mrbean-bremen
force-pushed
the
class_setup
branch
from
548fdf3
to
728ee1c
Compare
|
|
||
|
|
||
| class ExampleTestCase(TestCase): | ||
| def setUpClass(cls): |
There was a problem hiding this comment.
Shouldn't there be an @classmethod as decorator?
There was a problem hiding this comment.
Yes, looks like I botched the example... thanks, will correct this!
|
|
||
| class ExampleTestCase(TestCase): | ||
| def setUpClass(cls): | ||
| self.setUpClassPyfakefs() |
| class ExampleTestCase(TestCase): | ||
| def setUpClass(cls): | ||
| self.setUpClassPyfakefs() | ||
| cls.file_path = "/test/file.txt" |
There was a problem hiding this comment.
Why so complicated? ;)
Just do
pathlib.Path('/test/file.txt').touch()
Isn't one of the great things of your package that I can do all file operations as usual because your package does the patching in background for me. No need to use fake_fs() or create_file(). Or do I misunderstand something?
There was a problem hiding this comment.
No, you understand correctly, this is just to demonstrate that you can access the fake fs from there, say to setup things that cannot be done in the real fs (like setting the file system size). But I may change this to make this more clear.
There was a problem hiding this comment.
I should have waited for a review before merging this - I tend to overlook simple stuff like that myself, especially in the evenings after my day job... next time.
|
The GitHub review mechanic do not show the correct lines here in my comments. But I hope you can understand them also. |
Tasks