Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #271: Use parametrize markers params for getting example_kwargs #272

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions pytest_bdd/reporting.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
import time

from .feature import force_unicode
from .utils import get_parametrize_markers_args
from .utils import get_parametrize_markers_args, get_parametrize_params


class StepReport(object):
Expand Down Expand Up @@ -73,20 +73,30 @@ def __init__(self, scenario, node):
"""
self.scenario = scenario
self.step_reports = []
self.param_index = None

parametrize_args = get_parametrize_markers_args(node)
if parametrize_args and scenario.examples:
param_names = parametrize_args[0] if isinstance(parametrize_args[0], (tuple, list)) else [
parametrize_args[0]]
param_values = parametrize_args[1]
params = get_parametrize_params(parametrize_args)

self.param_index = self.get_param_index(node, params)
self.example_kwargs = self.get_example_kwargs(node, params)

def get_param_index(self, node, params):
if params:
param_names = params[0]['names']
param_values = params[0]['values']
node_param_values = [node.funcargs[param_name] for param_name in param_names]
if node_param_values in param_values:
self.param_index = param_values.index(node_param_values)
return param_values.index(node_param_values)
elif tuple(node_param_values) in param_values:
self.param_index = param_values.index(tuple(node_param_values))
self.example_kwargs = {
example_param: force_unicode(node.funcargs[example_param])
for example_param in scenario.get_example_params()
return param_values.index(tuple(node_param_values))
return None

def get_example_kwargs(self, node, params):
params_names = (param['names'] for param in params)
all_names = sum(params_names, [])
return {
example_param_name: force_unicode(node.funcargs[example_param_name])
for example_param_name in all_names
}

@property
Expand Down
30 changes: 30 additions & 0 deletions pytest_bdd/utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -110,3 +110,33 @@ def get_markers_args_using_iter_markers(node, mark_name):
def get_markers_args_using_get_marker(node, mark_name):
"""Deprecated on pytest>=3.6"""
return getattr(node.get_marker(mark_name), 'args', ())


def get_parametrize_params(parametrize_args):
"""Group parametrize markers arguments names and values.

:param parametrize_args: parametrize markers arguments.
:return: `list` of `dict` in the form of:
[
{
"names": ["name1", "name2", ...],
"values": [value1, value2, ...],
},
...
]
"""
params = []
for i in range(0, len(parametrize_args), 2):
params.append({
'names': _get_param_names(parametrize_args[i]),
'values': parametrize_args[i+1]
})
return params


def _get_param_names(names):
youtux marked this conversation as resolved.
Show resolved Hide resolved
if not isinstance(names, (tuple, list)):
# As pytest.mark.parametrize has only one param name,
# it is not returned as a list. Convert it to list:
names = [names]
return names
youtux marked this conversation as resolved.
Show resolved Hide resolved
1 change: 1 addition & 0 deletions tests/feature/outline_feature.feature
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ Feature: Outline
| start | eat | left |
| 12 | 5 | 7 |
| 5 | 4 | 1 |
| 4 | 2 | 2 |

Scenario Outline: Outlined given, when, thens
Given there are <start> <fruits>
Expand Down
4 changes: 4 additions & 0 deletions tests/feature/parametrized.feature
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,7 @@ Scenario: Parametrized given, when, thens
Given there are <start> cucumbers
When I eat <eat> cucumbers
Then I should have <left> cucumbers


Scenario: Parametrized given - single param
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this test asserting? There is no "then" step

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You already have asked that question :). Shall we add comment somewhere in the code explaining what this test is testing?

#272 (comment)

Given there are <start> cucumbers
2 changes: 1 addition & 1 deletion tests/feature/test_outline.py
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ def should_have_left_fruits(start_fruits, start, eat, left, fruits):
def test_outlined_feature(request):
assert get_parametrize_markers_args(request.node) == (
['start', 'eat', 'left'],
[[12, 5.0, '7'], [5, 4.0, '1']],
[[12, 5.0, '7'], [5, 4.0, '1'], [4, 2.0, '2']],
youtux marked this conversation as resolved.
Show resolved Hide resolved
['fruits'],
[[u'oranges'], [u'apples']]
)
11 changes: 11 additions & 0 deletions tests/feature/test_parametrized.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,17 @@ def test_parametrized(request, start, eat, left):
"""Test parametrized scenario."""


@pytest.mark.parametrize(
'start', [12]
)
@scenario(
'parametrized.feature',
'Parametrized given - single param',
)
def test_parametrized_single_param(request, start):
youtux marked this conversation as resolved.
Show resolved Hide resolved
"""Test parametrized scenario."""


@pytest.fixture(params=[1, 2])
def foo_bar(request):
return 'bar' * request.param
Expand Down