-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let gherkin-terminal-reporter-expanded enable gherkin output #275
base: master
Are you sure you want to change the base?
Let gherkin-terminal-reporter-expanded enable gherkin output #275
Conversation
As we have now working CI tests, please review this pull request and merge if all is ok. |
@@ -43,5 +43,10 @@ Feature: Gherkin terminal reporter | |||
|
|||
Scenario: Should step parameters be replaced by their values | |||
Given there is gherkin scenario outline implemented | |||
When tests are run with step expanded mode | |||
When tests are run with step expanded option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make it clearer to have a step like "when tests are run with --gherkin-terminal-reporter-expanded". What do you think?
|
||
Scenario: Should step parameters be replaced by their values also when used together with gherkin reporter option | ||
Given there is gherkin scenario outline implemented | ||
When tests are run with step expanded and gherkin reporter options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would make it clearer to have a step like "when tests are run with --gherkin-terminal-reporter --gherkin-terminal-reporter-expanded".
Also, these 2 tests are basically the same, the only thing that differ is the options. Should we instead parametrize the options in the scenario outline and have 1 scenario definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I moved both tests into parameterized scenario :)
Blocked by #292 |
PR updated and ready for review |
Related to:
#247
#235
This pull request updates
--gherkin-terminal-reporter-expanded
to enable gherkin output.Thanks to that it can be used without adding
--gherkin-terminal-reporter
to the command.This is the way suggested in the docs:
https://pytest-bdd.readthedocs.io/en/latest/#reporting