Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let gherkin-terminal-reporter-expanded enable gherkin output #275

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sliwinski-milosz
Copy link
Contributor

Related to:
#247
#235

This pull request updates --gherkin-terminal-reporter-expanded to enable gherkin output.
Thanks to that it can be used without adding --gherkin-terminal-reporter to the command.

This is the way suggested in the docs:
https://pytest-bdd.readthedocs.io/en/latest/#reporting

@coveralls
Copy link

coveralls commented Nov 24, 2018

Coverage Status

Coverage remained the same at 93.545% when pulling 85c1893 on sliwinski-milosz:enable_gherkin_output_with_expand_option into 72a8764 on pytest-dev:master.

@sliwinski-milosz
Copy link
Contributor Author

As we have now working CI tests, please review this pull request and merge if all is ok.

@@ -43,5 +43,10 @@ Feature: Gherkin terminal reporter

Scenario: Should step parameters be replaced by their values
Given there is gherkin scenario outline implemented
When tests are run with step expanded mode
When tests are run with step expanded option
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make it clearer to have a step like "when tests are run with --gherkin-terminal-reporter-expanded". What do you think?


Scenario: Should step parameters be replaced by their values also when used together with gherkin reporter option
Given there is gherkin scenario outline implemented
When tests are run with step expanded and gherkin reporter options
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would make it clearer to have a step like "when tests are run with --gherkin-terminal-reporter --gherkin-terminal-reporter-expanded".
Also, these 2 tests are basically the same, the only thing that differ is the options. Should we instead parametrize the options in the scenario outline and have 1 scenario definition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved both tests into parameterized scenario :)

@sliwinski-milosz
Copy link
Contributor Author

Blocked by #292

@sliwinski-milosz
Copy link
Contributor Author

PR updated and ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants