-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gettext support #306
base: master
Are you sure you want to change the base?
Add gettext support #306
Conversation
520a559
to
e24265b
Compare
@youtux, @olegpidsadnyi and @sliwinski-milosz Hello guys, I have to change the tox/travis settings because the pytest 4.5 and after are crashing the tests. |
e24265b
to
d80157e
Compare
Travis has been fixed on master so you can revert your travis related changes |
d80157e
to
4a52482
Compare
@sliwinski-milosz |
To be honest I don't really understand why do we need gettext for 11 keywords. This seems like an overkill. Another point is the current language. I think this should be a pytest option that the plugin introduces. |
The whole point is to be compatible with the cucumber? To let people use pytetst instead of cucumber? Then the language support is like this: #language header, and only keywords. There's no need in gettext. This is just a simple dict lookup once the header is set on the feature file. Otherwise english. See https://github.com/cucumber/gherkin-python/blob/master/gherkin/gherkin-languages.json |
@olegpidsadnyi and @youtux I really want to see multiple languages support on I can change my PR to fit the needs of the project. |
@dutradda, if you are willing to work on this, I would propose to continue in this way:
I am not sure how much work it would require, but I think it is a viable option. |
@youtux |
@youtux is this still relevant/needed? |
Good point. I've got a few other issues that just need asserting and tests to close them. I'll add this to them |
First translation was written for portuguese, according to https://cucumber.io/docs/gherkin/reference/#spoken-languages.
The PR also enables the language reset during runtime.