Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Given, When and Then in feature description #377

Closed
wants to merge 2 commits into from

Conversation

jirikuncar
Copy link
Member

Raise only warning for following feature:

        Feature: Description

            In order to achieve something
            I want something
            Because it will be cool
            Given it is valid description
            When it starts working
            Then I will be happy


            Some description goes here.

            Scenario: Description
                Given I have a bar

@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.52%. Comparing base (8008c0f) to head (1e6bba8).
Report is 570 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
+ Coverage   95.51%   95.52%   +0.01%     
==========================================
  Files          48       48              
  Lines        1671     1677       +6     
  Branches      167      168       +1     
==========================================
+ Hits         1596     1602       +6     
  Misses         43       43              
  Partials       32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jirikuncar
Copy link
Member Author

This can be resolved by using official parser (see #378).

@jirikuncar
Copy link
Member Author

@olegpidsadnyi can you please have a look at this patch? It would help until the official parser is used. Thanks!

@jsa34
Copy link
Collaborator

jsa34 commented Sep 27, 2024

Resolved now we are using the official parser. Added test here: #710

@jsa34
Copy link
Collaborator

jsa34 commented Sep 28, 2024

@youtux can this now be closed as it's no longer an issue?

@youtux youtux closed this Sep 28, 2024
@youtux
Copy link
Contributor

youtux commented Sep 28, 2024

Yes!

@youtux
Copy link
Contributor

youtux commented Sep 28, 2024

Sorry @jirikuncar this went under my radar, but now it’s fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants