Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule feature #728

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Add rule feature #728

wants to merge 12 commits into from

Conversation

jsa34
Copy link
Collaborator

@jsa34 jsa34 commented Oct 20, 2024

Add changelog entry
Add README entry
Add tests
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 91.07143% with 10 lines in your changes missing coverage. Please review.

Project coverage is 95.38%. Comparing base (4d995b2) to head (5ebf4ea).

Files with missing lines Patch % Lines
src/pytest_bdd/generation.py 54.54% 3 Missing and 2 partials ⚠️
src/pytest_bdd/gherkin_terminal_reporter.py 72.22% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
- Coverage   95.60%   95.38%   -0.22%     
==========================================
  Files          54       55       +1     
  Lines        2092     2188      +96     
  Branches      229      247      +18     
==========================================
+ Hits         2000     2087      +87     
- Misses         56       62       +6     
- Partials       36       39       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsa34
Copy link
Collaborator Author

jsa34 commented Oct 20, 2024

@youtux Created a new PR with the rule feature in as I messed up the rebasing!

@jsa34 jsa34 requested a review from youtux October 20, 2024 18:01
README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
src/pytest_bdd/generation.py Outdated Show resolved Hide resolved
src/pytest_bdd/generation.py Outdated Show resolved Hide resolved
src/pytest_bdd/gherkin_terminal_reporter.py Outdated Show resolved Hide resolved
tests/feature/test_gherkin_terminal_reporter.py Outdated Show resolved Hide resolved
tests/feature/test_rule_example_format.py Outdated Show resolved Hide resolved
tests/feature/test_rule_example_format.py Outdated Show resolved Hide resolved
tests/feature/test_rule_example_format.py Outdated Show resolved Hide resolved
tests/feature/test_rule_example_format.py Outdated Show resolved Hide resolved
@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 5, 2024

Implemented all feedback.

Just this: #728 (comment) I think needs to be as it is, so we know what type of background it is (under a feature or under rule), but may have misunderstood the suggestion!

@Poogles
Copy link

Poogles commented Nov 7, 2024

Hero thanks for implementing this and the data tables work. <3

@jsa34
Copy link
Collaborator Author

jsa34 commented Nov 7, 2024

Pleasure!

Glad it is hopefully helpful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rule keyword
3 participants