-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rule feature #728
base: master
Are you sure you want to change the base?
Add rule feature #728
Conversation
Add changelog entry Add README entry Add tests
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #728 +/- ##
==========================================
- Coverage 95.60% 95.38% -0.22%
==========================================
Files 54 55 +1
Lines 2092 2188 +96
Branches 229 247 +18
==========================================
+ Hits 2000 2087 +87
- Misses 56 62 +6
- Partials 36 39 +3 ☔ View full report in Codecov by Sentry. |
@youtux Created a new PR with the rule feature in as I messed up the rebasing! |
Co-authored-by: Alessio Bogon <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>
Co-authored-by: Alessio Bogon <[email protected]>
# Conflicts: # CHANGES.rst
Implemented all feedback. Just this: #728 (comment) I think needs to be as it is, so we know what type of background it is (under a feature or under rule), but may have misunderstood the suggestion! |
Hero thanks for implementing this and the data tables work. <3 |
Pleasure! Glad it is hopefully helpful! |
Resolves Rule keyword #511