Skip to content

Commit

Permalink
Fix for #806 (if results table order changed, hide/show details hover…
Browse files Browse the repository at this point in the history
… over broken) (#807)

* Fix for #806
  • Loading branch information
volkan-aslan authored Apr 24, 2024
1 parent 4b714aa commit 38b8a6c
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/pytest_html/scripts/dom.js
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,10 @@ const dom = {
}

if (collapsed) {
resultBody.querySelector('.collapsible > td')?.classList.add('collapsed')
resultBody.querySelector('.collapsible > .col-result')?.classList.add('collapsed')
resultBody.querySelector('.extras-row').classList.add('hidden')
} else {
resultBody.querySelector('.collapsible > td')?.classList.remove('collapsed')
resultBody.querySelector('.collapsible > .col-result')?.classList.remove('collapsed')
}

const media = []
Expand Down
18 changes: 18 additions & 0 deletions testing/test_integration.py
Original file line number Diff line number Diff line change
Expand Up @@ -870,6 +870,24 @@ def test_CCC():
for row, expected in zip(result, order):
assert_that(row.string).contains(expected)

def test_collapsed_class_when_results_table_order_changed(self, pytester):
pytester.makeconftest(
"""
def pytest_html_results_table_header(cells):
cells.append(cells.pop(0))
def pytest_html_results_table_row(report, cells):
cells.append(cells.pop(0))
"""
)
pytester.makepyfile("def test_pass(): pass")
page = run(pytester)
assert_results(page, passed=1)

assert_that(
get_text(page, "#results-table td[class='col-result collapsed']")
).is_true()


class TestLogCapturing:
LOG_LINE_REGEX = r"\s+this is {}"
Expand Down

0 comments on commit 38b8a6c

Please sign in to comment.