Fix: Logging issues with teardown #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeyondEvil
force-pushed
the
beyondevil/fix-rerun-logging
branch
from
1359f1a
to
8087685
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to be multiple issues with
pytest-rerunfailuresand/orpytestrelated to captured logs.More info here: pytest-dev/pytest-rerunfailures#124
Until they have been fixed or I've figured out exactly what the problem is, we won't attach logs to "reruns".
Not that there's still an issue where "teardown" logs are added multiple times in the output from
pytest. Which in turn means that's what ends up in the report.