Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdb: only use outcomes.exit via do_quit #5236

Merged
merged 1 commit into from
May 9, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented May 8, 2019

Fixes #5235.

@blueyed blueyed requested a review from asottile May 8, 2019 22:38
Copy link
Member

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented May 8, 2019

Codecov Report

Merging #5236 into features will decrease coverage by 1.49%.
The diff coverage is 77.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##           features    #5236     +/-   ##
===========================================
- Coverage     96.14%   94.65%   -1.5%     
===========================================
  Files           115      115             
  Lines         26125    26139     +14     
  Branches       2577     2578      +1     
===========================================
- Hits          25118    24741    -377     
- Misses          706     1083    +377     
- Partials        301      315     +14
Impacted Files Coverage Δ
src/_pytest/debugging.py 88.82% <60%> (-0.36%) ⬇️
testing/test_pdb.py 98.82% <84.61%> (-0.38%) ⬇️
testing/test_pluginmanager.py 49.57% <0%> (-50.43%) ⬇️
testing/test_pytester.py 54.04% <0%> (-35.27%) ⬇️
testing/test_terminal.py 86.78% <0%> (-13.07%) ⬇️
src/_pytest/pytester.py 86.8% <0%> (-4.83%) ⬇️
src/_pytest/terminal.py 92.02% <0%> (-1.4%) ⬇️
testing/test_recwarn.py 98.3% <0%> (-1.28%) ⬇️
testing/test_runner.py 95.87% <0%> (-1.09%) ⬇️
src/_pytest/config/__init__.py 93.79% <0%> (-0.64%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5eeb5ee...73b74c7. Read the comment docs.

testing/test_pdb.py Outdated Show resolved Hide resolved
@blueyed blueyed force-pushed the pdb-eoferror-quit branch from f1c53a1 to c0bd010 Compare May 9, 2019 08:29
@blueyed blueyed closed this May 9, 2019
@blueyed blueyed reopened this May 9, 2019
@blueyed blueyed force-pushed the pdb-eoferror-quit branch from c0bd010 to 3256d01 Compare May 9, 2019 10:25
@blueyed blueyed closed this May 9, 2019
@blueyed blueyed reopened this May 9, 2019
@blueyed blueyed force-pushed the pdb-eoferror-quit branch from 3256d01 to 73b74c7 Compare May 9, 2019 12:56
@blueyed blueyed merged commit ceca35b into pytest-dev:features May 9, 2019
@blueyed blueyed deleted the pdb-eoferror-quit branch May 9, 2019 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants