-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PostgreSQL handler #635
Open
cgalisteo
wants to merge
2
commits into
python-diamond:master
Choose a base branch
from
cgalisteo:postgresql-handler
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,110 @@ | ||
# coding=utf-8 | ||
|
||
""" | ||
Insert the collected values into a table | ||
""" | ||
|
||
from Handler import Handler | ||
import psycopg2 | ||
|
||
|
||
class PostgreSQLHandler(Handler): | ||
""" | ||
Implements the abstract Handler class, sending data to a mysql table | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. mysql should be postgresql |
||
""" | ||
conn = None | ||
|
||
def __init__(self, config=None): | ||
""" | ||
Create a new instance of the PostgreSQLHandler class | ||
""" | ||
# Initialize Handler | ||
Handler.__init__(self, config) | ||
|
||
# Initialize Options | ||
self.hostname = self.config['hostname'] | ||
self.port = int(self.config['port']) | ||
self.username = self.config['username'] | ||
self.password = self.config['password'] | ||
self.database = self.config['database'] | ||
self.table = self.config['table'] | ||
self.col_time = self.config['col_time'] | ||
self.col_metric = self.config['col_metric'] | ||
self.col_value = self.config['col_value'] | ||
|
||
# Connect | ||
self._connect() | ||
|
||
def get_default_config_help(self): | ||
""" | ||
Returns the help text for the configuration options for this handler | ||
""" | ||
config = super(PostgreSQLHandler, self).get_default_config_help() | ||
|
||
config.update({ | ||
}) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add descriptions for all the config options? |
||
|
||
return config | ||
|
||
def get_default_config(self): | ||
""" | ||
Return the default config for the handler | ||
""" | ||
config = super(PostgreSQLHandler, self).get_default_config() | ||
|
||
config.update({ | ||
}) | ||
|
||
return config | ||
|
||
def __del__(self): | ||
""" | ||
Destroy instance of the PostgreSQLHandler class | ||
""" | ||
self._close() | ||
|
||
def process(self, metric): | ||
""" | ||
Process a metric | ||
""" | ||
# Just send the data | ||
self._send(str(metric)) | ||
|
||
def _send(self, data): | ||
""" | ||
Insert the data | ||
""" | ||
data = data.strip().split(' ') | ||
try: | ||
cursor = self.conn.cursor() | ||
cursor.execute("INSERT INTO %s (%s, %s, %s) VALUES(%%s, %%s, %%s)" | ||
% (self.table, self.col_metric, | ||
self.col_time, self.col_value), | ||
(data[0], data[2], data[1])) | ||
cursor.close() | ||
self.conn.commit() | ||
except BaseException, e: | ||
# Log Error | ||
self.log.error("PostgreSQLHandler: Failed sending data. %s.", e) | ||
self.log.error(e) | ||
# Attempt to restablish connection | ||
self._connect() | ||
|
||
def _connect(self): | ||
""" | ||
Connect to the PostgreSQL server | ||
""" | ||
self._close() | ||
self.conn = psycopg2.connect(host=self.hostname, | ||
port=self.port, | ||
user=self.username, | ||
password=self.password, | ||
dbname=self.database) | ||
|
||
def _close(self): | ||
""" | ||
Close the connection | ||
""" | ||
if self.conn: | ||
self.conn.commit() | ||
self.conn.close() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace double space near end with postgreSQL