Allow setting mypy/dmypy commands via config #91
+141
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems like this PR would resolve #90/rgbkrk/python-lsp-zed-extension#4 as well |
vrslev
reviewed
Sep 30, 2024
| command_key = f"{cmd}_command" | ||
| command: List[str] = settings.get(command_key, []) | ||
|
|
||
| if not command and shutil.which(cmd): |
There was a problem hiding this comment.
This would be easier to comprehend:
if command:
return command
if shutil.which(cmd):
...
return [cmd]
return commandAlso, it looks like there is a hidden bug: if command is empty and shutil.which(cmd) == False, empty list would be returned, which is undesirable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #57. Instead of requiring an external command to provide the commands to run
mypyordmypyare taken from configuration.