Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add window/logMessage support #573

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

Dylmay
Copy link
Contributor

@Dylmay Dylmay commented Jun 20, 2024

This PR adds support for logging to the LSP client through the window/logMessage command

See: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#window_logMessage

@Dylmay
Copy link
Contributor Author

Dylmay commented Jul 8, 2024

@ccordoba12, could I have a review

@ccordoba12 ccordoba12 added the enhancement New feature or request label Jul 24, 2024
@ccordoba12 ccordoba12 added this to the v1.12.0 milestone Jul 24, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @Dylmay!

Note: I rebased and pushed a commit to your branch only to fix our linting workflow.

@ccordoba12 ccordoba12 merged commit e8dd582 into python-lsp:develop Jul 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants