Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add validator for trx addresses #384

Merged
merged 3 commits into from
Jul 4, 2024
Merged

feat: add validator for trx addresses #384

merged 3 commits into from
Jul 4, 2024

Conversation

msamsami
Copy link
Contributor

@msamsami msamsami commented Jul 2, 2024

  • A new validator is added for the Tron (TRC20) address

yozachar
yozachar requested changes Jul 3, 2024
View reviewed changes
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Show resolved Hide resolved
@msamsami
Copy link
Contributor Author

msamsami commented Jul 3, 2024

@yozachar All done.

yozachar
yozachar approved these changes Jul 4, 2024
View reviewed changes
Copy link
Collaborator

@yozachar yozachar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yozachar yozachar merged commit 860ca46 into python-validators:master Jul 4, 2024
17 checks passed
@yozachar yozachar self-assigned this Jul 4, 2024
@yozachar yozachar added the enhancement Issue/PR: A new feature label Jul 4, 2024
@yozachar
Copy link
Collaborator

yozachar commented Jul 4, 2024

@msamsami, there's is something odd about the Table of Contents in the crypto_address documentation see: https://yozachar.github.io/pyvalidators/stable/api/crypto_addresses/, any idea why?

@msamsami
Copy link
Contributor Author

msamsami commented Jul 4, 2024

@msamsami, there's is something odd about the Table of Contents in the crypto_address documentation see: https://yozachar.github.io/pyvalidators/stable/api/crypto_addresses/, any idea why?

The table of contents in the right sidebar? I noticed it just now. I ran the python package/export TYPE commands once again. No changes to the files! And it's the same on local—no idea why!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yozachar yozachar yozachar approved these changes

Assignees

@yozachar yozachar

Labels
enhancement Issue/PR: A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msamsami @yozachar